Included more robust client side validation#1513
Included more robust client side validation#1513Roshan-Metrix wants to merge 3 commits intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@Roshan-Metrix please fix branch conflicts |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the client-side validation for login and registration forms by adding pre-submission validation functions and fixes a UI bug related to currency display. The changes prevent unnecessary API calls by validating user input before attempting backend interactions.
- Added
validateLogin()andvalidateRegister()functions for client-side form validation - Integrated validation checks into existing login and registration flows
- Fixed currency display element ID from
balance-currencytocurrency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@Roshan-Metrix please fix the branch conflict |
|
This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date. |
2 participants
Included more robust client side validation
I've added two new functions, validateLogin() and validateRegister(), which check for empty fields on the respective forms. The login() and register() functions now call these validation functions before attempting to interact with the simulated backend. This ensures that the user is immediately notified of any missing information. I also corrected the id for the currency display on the dashboard from balance-currency to currency.
Key Improvements
Impact